-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix question listing and navigation in quiz reports #12359
Conversation
Simplify and fix attempt log listing. Remove background to show selection state.
Build Artifacts
|
Hi @rtibbles, everything seems ok but noticed 2 issues that can potentially cause confusion:
2024-06-26_16-29-09.mp4 |
Thanks @pcenov - definitely useful to add an indicator at the section level too - I will use the same background colour. Will make sure that the titles match! |
Have global question numbers in reports. Add section descriptions if they exist.
…h reports. Cleanup unnecessary props, computed props, and vuex getters.
Hi @pcenov I have fixed both these issues, and moved to a consistent 'global across the quiz' question numbering. To be completely consistent, I have also updated this for learners taking the quiz too, so additional testing there would be very useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rtibbles LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding the context for all of this is a bit of a challenge, but that's a factor of the complexity of some of this code. One non-blocking suggestion for an additional comment
Summary
References
Fixes #12334
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)