trying to fix integrity errors before migrating tables #12279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jredrejo
added this to the Kolibri 0.17: General maintenance, bugs, misc. important fixes milestone
github-actions
bot
added
DEV: backend
Build Artifacts
|
rtibbles
requested changes
Jun 14, 2024
kolibri/utils/main.py
Outdated
| @@ -185,6 +186,27 @@ def _copy_preseeded_db(db_name, target=None): | |||
| ) | |||
|
|
|||
|
|
|||
| def sqlite_check_foreign_keys(): | |||
| db_connection = connections["default"] | |||
There was a problem hiding this comment.
This is explicitly being done in the method that is before Django setup, so I think using the django DB connection here might not be a good idea. Could you instead generate the connection directly using the Python sqlite library?
We should also iterate over all the SQLite databases listed in https://github.com/learningequality/kolibri/blob/develop/kolibri/deployment/default/sqlite_db_names.py#L14 to be safe.
There was a problem hiding this comment.
argg, got it. Thanks for the advice
Changed as requested
jredrejo
force-pushed
the
pragma_integrity_check
branch
from
c4c94d7
to
132e318
Compare
rtibbles
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Code looks right, I'll test it with the database that @AllanOXDi had with the original issue. Thanks!
rtibbles
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before updating kolibri database on a Django upgrade, check integrity of the tables and fix automatically errors that can be safely fixed
References
Closes: #12138
Reviewer guidance
Using a broken db, check that it's fixed.
Using a good db, check no problems are added
Testing checklist
PR process
Reviewer checklist
yarnandpip)