-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to allow and implement randomization of sections. #12278
Update to allow and implement randomization of sections. #12278
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes here look fine, with the exception of one thing that seems like a bug and is making the UX a bit weird. Otherwise, I have one improvement idea about to the UX is worth making that I hadn't considered until I started playing around with it in manual QA.
First, I create a quiz that I want a fixed section order, but random questions:
Before I assign the quiz, while I can still edit, I go back into the quiz, and the default seems to be "randomized" not what I have saved (this feels like a bug)
Then (my idea of a UI update) in the coach reports, I think adding a distinction between section order and question order would also be helpful, because I think right now they are still conflated.
Maybe both "section order" and "question order" explained on the side? I'm not really sure how this would interact with the other quiz section report work so maybe it would be best done in follow up, actually..... I can open a follow up issue if that's preferable to fit into the changes made there, rather than try to sort that out now.
But the radio button stuff does seem worth fixing.
:layout4="{ span: 2 }" | ||
> | ||
<KRadioButton | ||
:currentValue="quiz.learners_see_fixed_order" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's something going on here with the saving/setting current value that is changing the saved value on edit, that I'm pretty sure is a bug although I can't see on code read through where precisely it's happening (see screenshot in overall PR comment)
@rtibbles here's a video since the screenshots I shared was the wrong one: fix-sections-random-questions.mov |
Looks like the issue you are seeing is actually caused by the fact that we're not actually saving the field to the backend! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates @rtibbles
Summary
References
Fixes #12248
Reviewer guidance
Check that when creating a quiz, the section ordering can be randomized or set fixed, and that the learner experience of the quiz accords to this.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)