Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to allow and implement randomization of sections. #12278

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Changes description for the global 'learner_sees_fixed_order' flag to be about the section ordering, not questions
  • Allows editing this flag in the quiz creation/editing flow
  • Updates the learner experience to randomize the section order if this is set to false.

References

Fixes #12248

Reviewer guidance

Check that when creating a quiz, the section ordering can be randomized or set fixed, and that the learner experience of the quiz accords to this.

Screenshot from 2024-06-13 07-46-09


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small labels Jun 13, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes here look fine, with the exception of one thing that seems like a bug and is making the UX a bit weird. Otherwise, I have one improvement idea about to the UX is worth making that I hadn't considered until I started playing around with it in manual QA.

First, I create a quiz that I want a fixed section order, but random questions:
Screenshot 2024-06-13 at 12 52 17 PM

Before I assign the quiz, while I can still edit, I go back into the quiz, and the default seems to be "randomized" not what I have saved (this feels like a bug)
Screenshot 2024-06-13 at 12 51 37 PM

Then (my idea of a UI update) in the coach reports, I think adding a distinction between section order and question order would also be helpful, because I think right now they are still conflated.
Screenshot 2024-06-13 at 12 49 34 PM

Maybe both "section order" and "question order" explained on the side? I'm not really sure how this would interact with the other quiz section report work so maybe it would be best done in follow up, actually..... I can open a follow up issue if that's preferable to fit into the changes made there, rather than try to sort that out now.

But the radio button stuff does seem worth fixing.

:layout4="{ span: 2 }"
>
<KRadioButton
:currentValue="quiz.learners_see_fixed_order"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something going on here with the saving/setting current value that is changing the saved value on edit, that I'm pretty sure is a bug although I can't see on code read through where precisely it's happening (see screenshot in overall PR comment)

@marcellamaki
Copy link
Member

@rtibbles here's a video since the screenshots I shared was the wrong one:

fix-sections-random-questions.mov

@rtibbles
Copy link
Member Author

Looks like the issue you are seeing is actually caused by the fact that we're not actually saving the field to the backend!

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates @rtibbles

@rtibbles rtibbles merged commit 5b207a0 into learningequality:develop Jun 14, 2024
31 checks passed
@rtibbles rtibbles deleted the randomize_sections branch June 14, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: medium SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When editing a quiz the 'Question order' value is always displayed as 'Randomized'
2 participants