Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transform to ensure proper layering in Safari. #12213

Merged
merged 1 commit into from
May 27, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented May 27, 2024

Summary

  • Fixes Safari specific issue with z-index resolution

References

Fixes #12212

Reviewer guidance

Screenshot from 2024-05-27 08-27-24


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link

ellipsis-dev bot commented May 27, 2024

Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month or reach us at help@ellipsis.dev

@github-actions github-actions bot added APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend labels May 27, 2024
@radinamatic
Copy link
Member

Tested in Browserstack, with Safari 15.6 and 17.6, LGTM 👍🏽

15.6 17.6
safari3 safari4

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship this to get the RC going! 🚀

@rtibbles rtibbles merged commit 01cfaeb into learningequality:release-v0.16.x May 27, 2024
34 checks passed
@rtibbles rtibbles deleted the surfin_safari branch May 27, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants