Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update background #12208

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

rtibbles
Copy link
Member

Summary

  • Cherry picks Refactor default_theme paths/structure #12207 back into 0.16.x where it was meant to be targeted
  • Updates the background image for the rebrand
  • Updates how we display the background image, allowing us to apply a blur filter on compatible browsers (most browsers that we support, except IE11) to prevent the image looking lower quality on higher resolution screens. This was previously masked by the use of a higher opacity overlay on the image, but this has been reduced in order to make colors in the background image more vibrant.

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend SIZE: medium labels May 24, 2024
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it locally and it looks awesome -- totally jives with the new theme much better.

Just one question - why the move of the static/assets/default_theme into kolibri core from the default_theme plugin?

@rtibbles
Copy link
Member Author

Just one question - why the move of the static/assets/default_theme into kolibri core from the default_theme plugin?

This was a result of my putting a lot of these images in the wrong place, and then @marcellamaki cleaning them up somewhat. But I do think they could be put into the default theme plugin static folder instead of the core static folder (that was a result of my miscommunicating the cleanup to @marcellamaki, and missing this when I merged the PR). Will clean up now.

@rtibbles
Copy link
Member Author

Updated!

@nucleogenesis nucleogenesis self-requested a review May 24, 2024 18:52
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying! Code / dir updates look good

@radinamatic
Copy link
Member

Looking good in 3 browsers on both Ubuntu 20.04 and Windows 10:

Ubuntu Windows
Ubuntu20 04 Windows10

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@rtibbles rtibbles merged commit c002270 into learningequality:release-v0.16.x May 24, 2024
34 checks passed
@rtibbles rtibbles deleted the background_check branch May 24, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: backend Python, databases, networking, filesystem... DEV: frontend SIZE: medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants