-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate quizForge object references to composition API standard #11562
Migrate quizForge object references to composition API standard #11562
Conversation
Build Artifacts
|
ef789e1
to
d947678
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey I'm sorry for this. There are a few places that need to be updated it seems that maybe the rebase didn't quite apply as I'd expected it to. Happy to help clarify 1:1 if you have any questions
kolibri/plugins/coach/assets/src/composables/useQuizCreation.js
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/plan/CreateExamPage/CreateQuizSection.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/plan/CreateExamPage/CreateQuizSection.vue
Outdated
Show resolved
Hide resolved
kolibri/plugins/coach/assets/src/views/plan/CreateExamPage/CreateQuizSection.vue
Outdated
Show resolved
Hide resolved
d947678
to
f2c2c40
Compare
f2c2c40
to
5af7475
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks Prathamesh!
Summary
References
Closes #11546
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)