Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate quizForge object references to composition API standard #11562

Merged

Conversation

ozer550
Copy link
Member

@ozer550 ozer550 commented Nov 28, 2023

Summary

  • Migrate to using the composition API's way of using provide/inject.
  • Remove all instances of quizForge references and rather return the functions as necessary.

References

Closes #11546

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) SIZE: large labels Nov 28, 2023
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I'm sorry for this. There are a few places that need to be updated it seems that maybe the rebase didn't quite apply as I'd expected it to. Happy to help clarify 1:1 if you have any questions

@ozer550 ozer550 changed the title Feature quiz forge begone Migrate quizForge object references to composition API standard Dec 11, 2023
@ozer550 ozer550 marked this pull request as ready for review December 11, 2023 17:56
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks Prathamesh!

@nucleogenesis nucleogenesis merged commit c3995f8 into learningequality:develop Dec 12, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) SIZE: large SIZE: medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants