Warning fixes #11520
Merged
Warning fixes #11520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running with PYTHONWARNINGS=all reveals: ``` <venv>/lib/python3.9/site-packages/kolibri/utils/server.py:881: ResourceWarning: unclosed file <_io.TextIOWrapper name='<homedir>/server.pid' mode='r' encoding='UTF-8'> pid_file_lines = open(filename, "r").readlines() ResourceWarning: Enable tracemalloc to get the object allocation traceback ```
Running with PYTHONWARNINGS=all reveals: ``` <venv>/kolibri/utils/main.py:100: ResourceWarning: unclosed file <_io.TextIOWrapper name='<homedir>/.data_version' mode='r' encoding='UTF-8'> version = open(version_file(), "r").read() ```
Running with PYTHONWARNINGS=all reveals several deprecation warnings that `on_delete` must be specified for `ForeignKey` fields: ``` RemovedInDjango20Warning: on_delete will be a required arg for ForeignKey in Django 2.0. Set it to models.CASCADE on models and in existing migrations if you want to maintain the current default behavior. See https://docs.djangoproject.com/en/1.11/ref/models/fields/#django.db.models.ForeignKey.on_delete ```
github-actions
bot
added
DEV: backend
Build Artifacts
|
rtibbles
approved these changes
Nov 13, 2023
|
The modified code would either show an issue with no migrations (the migrations already have the cascade set), or have test coverage, so I don't see any concerns here. The cascade behaviour is most important for future Django upgrades once we drop Python 2.7 support. |
|
Smoke test locally running Kolibri shows no issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Running kolibri with
PYTHONWARNINGS=allshows several warnings. This PR fixes the ones within Kolibri (there are several others in dependencies) that I saw.References
None, just something I saw. Here is the original log I used to guide the changes.
Reviewer guidance
There should be no functional changes here, so just running Kolibri as usual to see if there are any regressions should be enough.
Testing checklist
PR process
Reviewer checklist
yarnandpip)