Garbage Collection Integration for Morango SyncSessions

[ozer550]

Summary

• Added CleanUpTaskOperation for queuing cleanupsync task passing relevant attributes.
• Cleanupsync Task to call cleanupsync command recently added in morango
• Override the command according to Integrate morango garbage collection #8238

Reviewer guidance

• Run the command using KOLIBRI_HOME=$(mktemp -d) kolibri manage cleanupsyncs
• Create two devices and try syncing, post_transfer hook gets triggered.

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

closes #8238

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b7.dev0_git.27.g1f200eda.pex
Windows Installer (EXE)	kolibri-0.16.0b7.dev0+git.27.g1f200eda-unsigned.exe
Debian Package	kolibri_0.16.0b7.dev0+git.27.g1f200eda-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b7.dev0+git.27.g1f200eda-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b7.dev0+git.27.g1f200eda-0.1.0-debug.apk
TAR file	kolibri-0.16.0b7.dev0+git.27.g1f200eda.tar.gz
WHL file	kolibri-0.16.0b7.dev0+git.27.g1f200eda-py2.py3-none-any.whl

[bjester]

Lets make sure to include the morango upgrade in this. We have yet to actually release it, so I will help get that sorted out later this week.

[bjester]

@ozer550 when you have a chance, could you upgrade morango to 0.6.17 here? That will complete this and ready it for merge!

[rtibbles]

Looks like this has been rebased to include the latest morango update - so I think this is ready to go?

[bjester]

Looks like this has been rebased to include the latest morango update - so I think this is ready to go?

It's pretty much there, but I didn't get a chance to talk to with Prathamesh about it during our sync yesterday. @ozer550 I think the instance ID filtering is the opposite of what it should be.

When we target sync sessions for clean up, if is_server is True on the completed sync, we would want to find all sync sessions with a matching instance client_instance_id. The is_server is in reference to the current device, so extracting the instance from client_instance_id would produce the other device's instance ID

[bjester]

@ozer550 The logic for which instance ID to use is still incorrect. Please take a closer, careful look at it. Could you also update the expiration to 1? I'm starting to think that 0 is a bad idea

[bjester]

🚀