Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buttons running together on the post setup modal #10957

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Jul 11, 2023

Summary

Before After
before after

References

Fixes #10886

Reviewer guidance

I wasn't able to test it in a regular way due to #10959, so you may run into the same problem too. I needed to temporarily tweak several places in the code responsible for displaying the modal to be able to preview it and make these fixes.

It's possible #10959 is only happening under certain circumstances so you can give it a try by

  1. Start a first facility
  2. Start a fresh instance of a second facility. In the setup wizard, follow Group learning > Full device > Import all data from an existing learning facility and import data from the first facility.
  3. After you're redirected to the Device Channels page, click Continue on the Welcome modal
  4. Preview the Select a source modal

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob marked this pull request as ready for review July 11, 2023 15:22
@MisRob MisRob requested a review from rtibbles July 18, 2023 15:37
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks correct to me! Thanks @MisRob

@rtibbles rtibbles self-assigned this Jul 18, 2023
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix manually confirmed.

@rtibbles rtibbles merged commit a0f89b2 into learningequality:develop Jul 18, 2023
@MisRob MisRob deleted the buttons-format branch February 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links run together in the PostSetupModal in Device
3 participants