Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove labels fetching for Channels in useBaseSearch #12841

Closed
3 tasks
nucleogenesis opened this issue Nov 13, 2024 · 0 comments · Fixed by #12877
Closed
3 tasks

Remove labels fetching for Channels in useBaseSearch #12841

nucleogenesis opened this issue Nov 13, 2024 · 0 comments · Fixed by #12877
Assignees
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend

Comments

@nucleogenesis
Copy link
Member

Overview

Follow-up to #12759 where a decision was made to remove the "Channels" label/option from the SearchFiltersPanel.

With this change, we no longer need to be fetching/processing the labels for this code so it can be removed from useBaseSearch.

Starting from around here:

and through the file dealing with channels-related things like:

channels: searchableLabels.channels ? searchableLabels.channels.map(c => c.id) : [],

and any other reference to channels labels.

Acceptance criteria

[Then, more detail. Provide a short summary and/or list key outcomes that the user should be able to accomplish with this feature.]

  • useBaseSearch no longer exposes availableChannels
  • useBaseSearch no longer processes anything to do with channels labels
  • useBaseSearch still however filters search results by whatever channel the user is currently on (test only in Learn until Quiz creation side panels improvements #12819 is closed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants