Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint rules to use rules from eslint/vue where possible #12199

Closed
rtibbles opened this issue May 23, 2024 · 7 comments · Fixed by #12757
Closed

Update eslint rules to use rules from eslint/vue where possible #12199

rtibbles opened this issue May 23, 2024 · 7 comments · Fixed by #12757
Assignees
Labels
DEV: tools Internal tooling for development help wanted Open source contributors welcome TAG: tech update / debt Change not visible to user

Comments

@rtibbles
Copy link
Member

Observed behavior

@MisRob created multiple custom eslint rules for Vue components, which she also contributed upstream to eslint/vue. Many of these rules are now in the main eslint/vue package.

Expected behavior

We should use these rules from upstream (e.g. https://eslint.vuejs.org/rules/no-unused-properties.html#vue-no-unused-properties) where possible, and remove the code and tests for unused rules in this repository.

@rtibbles rtibbles added TAG: tech update / debt Change not visible to user help wanted Open source contributors welcome DEV: tools Internal tooling for development labels May 23, 2024
@rtibbles rtibbles mentioned this issue May 23, 2024
9 tasks
@shubh1007
Copy link
Contributor

May I work on this issue?

@rtibbles
Copy link
Member Author

Hi @shubh1007 - that would be great! Before work can begin fully on this, this PR #9698 must be merged, but we are hoping to do that this coming week.

In the meantime, looking at the existing custom rules we have for vue components, which you can find in here: https://github.com/learningequality/kolibri/tree/develop/packages/eslint-plugin-kolibri/lib/rules and then seeing which ones will be redundant once we upgrade our vue eslint plugin version (see here for the complete list: https://eslint.vuejs.org/rules/) would be a great start!

I'll assign you, and if you can make a note of which rules you think you'll need to switch over in this issue, that would be super!

@shubh1007
Copy link
Contributor

Since the PR #9698 has been merged, I want to work upon this issue. Please describe the problem briefly so that I can understand the problem properly and resolve the issue.
Thank you.

@rtibbles
Copy link
Member Author

rtibbles commented Jul 2, 2024

We have some rules in our custom rules https://github.com/learningequality/kolibri/tree/develop/packages/eslint-plugin-kolibri/lib/rules that have equivalents in https://eslint.vuejs.org/rules/

Find the ones that we can remove from our custom rules and use the eslint/vuejs rules instead.

@MisRob
Copy link
Member

MisRob commented Sep 3, 2024

Hi @shubh1007, are you working on planning to work on this, or would it be better to unassign?

@shubh1007
Copy link
Contributor

You can unassign the task.

@MisRob
Copy link
Member

MisRob commented Sep 3, 2024

Alright, thanks for letting us know @shubh1007. Best wishes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: tools Internal tooling for development help wanted Open source contributors welcome TAG: tech update / debt Change not visible to user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants