-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslint rules to use rules from eslint/vue where possible #12199
Comments
May I work on this issue? |
Hi @shubh1007 - that would be great! Before work can begin fully on this, this PR #9698 must be merged, but we are hoping to do that this coming week. In the meantime, looking at the existing custom rules we have for vue components, which you can find in here: https://github.com/learningequality/kolibri/tree/develop/packages/eslint-plugin-kolibri/lib/rules and then seeing which ones will be redundant once we upgrade our vue eslint plugin version (see here for the complete list: https://eslint.vuejs.org/rules/) would be a great start! I'll assign you, and if you can make a note of which rules you think you'll need to switch over in this issue, that would be super! |
Since the PR #9698 has been merged, I want to work upon this issue. Please describe the problem briefly so that I can understand the problem properly and resolve the issue. |
We have some rules in our custom rules https://github.com/learningequality/kolibri/tree/develop/packages/eslint-plugin-kolibri/lib/rules that have equivalents in https://eslint.vuejs.org/rules/ Find the ones that we can remove from our custom rules and use the eslint/vuejs rules instead. |
Hi @shubh1007, are you working on planning to work on this, or would it be better to unassign? |
You can unassign the task. |
Alright, thanks for letting us know @shubh1007. Best wishes |
Observed behavior
@MisRob created multiple custom eslint rules for Vue components, which she also contributed upstream to eslint/vue. Many of these rules are now in the main eslint/vue package.
Expected behavior
We should use these rules from upstream (e.g. https://eslint.vuejs.org/rules/no-unused-properties.html#vue-no-unused-properties) where possible, and remove the code and tests for unused rules in this repository.
The text was updated successfully, but these errors were encountered: