Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom eslint rules that are redundant with eslint-plugin-vue rules. #12757

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Switches custom rules to use built in rules where possible
  • Deletes code and tests for unused custom rules

References

Fixes #12199

Reviewer guidance

Is all code cleaned up? Does linting still check out as expected?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: renderers HTML5 apps, videos, exercises, etc. APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend DEV: tools Internal tooling for development labels Oct 26, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all instances of no-unused-properties have been replaced with the vue version (confirmed by searching code base). I also didn't see any places where the custom kolibri rules:
vue-component-registration-casing
vue-filename-and-component-name-match

were used within files. But looking at the intention of the linting, and the vue replacement, these look like the correct updates to make in our eslint file.

@rtibbles rtibbles merged commit 3b49acb into learningequality:develop Oct 28, 2024
34 checks passed
@rtibbles rtibbles deleted the eslint_rules branch October 28, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend DEV: renderers HTML5 apps, videos, exercises, etc. DEV: tools Internal tooling for development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update eslint rules to use rules from eslint/vue where possible
2 participants