Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synchornize database when a TaskRequest is failed #216

Merged
merged 4 commits into from
Apr 24, 2024
Merged

synchornize database when a TaskRequest is failed #216

merged 4 commits into from
Apr 24, 2024

Conversation

ozer550
Copy link
Member

@ozer550 ozer550 commented Apr 11, 2024

closes #203

  • Updates task in the database to be marked as failed when its canceled from the Android side!

@ozer550 ozer550 requested a review from bjester April 15, 2024 07:54
bjester
bjester previously requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the necessary bits and pieces are here, but some restructuring is needed. Also, if you would please make sure your code is formatted in the same conventions as the existing code, e.g. spaces after if and between if conditions and operators.

python-for-android/dists/kolibri/src/main/java/org/learningequality/task/Worker.java Outdated Show resolved Hide resolved
python-for-android/dists/kolibri/src/main/java/org/learningequality/task/Worker.java Outdated Show resolved Hide resolved
python-for-android/dists/kolibri/src/main/java/org/learningequality/task/Worker.java Outdated Show resolved Hide resolved
python-for-android/dists/kolibri/src/main/java/org/learningequality/task/Worker.java Outdated Show resolved Hide resolved
@ozer550 ozer550 requested a review from bjester April 17, 2024 12:33
bjester
bjester reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, just some minor formatting updates needed. Mostly adding whitespace, and perhaps removing some extraneous semicolons

@bjester bjester self-requested a review April 22, 2024 15:53
@bjester bjester self-assigned this Apr 22, 2024
bjester
bjester approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! QA so far seems good to go, but lets wait to merge

@pcenov
Copy link
Member

pcenov commented Apr 24, 2024

Both me and @radinamatic didn't observe any new issues while syncing the devices - manual QA checks out!

@pcenov pcenov mentioned this pull request Apr 24, 2024
Closed
@bjester bjester merged commit 295ab42 into learningequality:develop Apr 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjester bjester bjester approved these changes

Assignees

@bjester bjester

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manually update task status when task is cancelled or an Android exception occurs during its execution
3 participants
@ozer550 @pcenov @bjester