Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweaks and cleanup #196

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Small tweaks and cleanup #196

wants to merge 4 commits into from

Conversation

bjester
Copy link
Member

@bjester bjester commented Jan 23, 2024

Summary

  • Removes file locking code, instead enforces reconciler only runs in the expected process, and uses thread locking
  • Ensures we listen to activity lifecycle events in the main app process, to prevent duplication
  • Separates step to load python libraries in worker implementation

@rtibbles rtibbles self-assigned this Jan 25, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me - limiting the life cycle hooks that are only relevant for the worker process, and tweaking where the Python library loading happens all seem sensible to me.

I tested locally on Android 13 in an emulator, and didn't note any regressions in task execution for foreground or background tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants