Skip to content

Commit

Permalink
Separate AAB building from play store upload, so we always get an AAB…
Browse files Browse the repository at this point in the history
… artifact even if upload fails.
  • Loading branch information
rtibbles committed Mar 29, 2024
1 parent 9377e52 commit 0f5915d
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/build_apk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,6 @@ jobs:
echo -n "${{ secrets.KOLIBRI_ANDROID_APP_PRODUCTION_KEYSTORE }}" | base64 --decode > production.keystore
export RELEASE_KEYSTORE=$(realpath production.keystore)
make kolibri.aab
# Upload to Play Store - this will also download the universal APK into the dist folder
make playstore-upload
- name: Get AAB filename
if: ${{ inputs.release == true || github.event.inputs.release == 'true' }}
id: get-aab-filename
Expand All @@ -177,6 +175,9 @@ jobs:
with:
name: ${{ steps.get-aab-filename.outputs.aab-file-name }}
path: dist/${{ steps.get-aab-filename.outputs.aab-file-name }}
- name: Upload the AAB to the Play Store and download the signed Universal APK
if: ${{ inputs.release == true || github.event.inputs.release == 'true' }}
run: make playstore-upload
- name: Build the apk
if: ${{ inputs.signed == true || github.event.inputs.signed == 'true' }}
env:
Expand Down

0 comments on commit 0f5915d

Please sign in to comment.