Merge pull request #28 from leanix/feature/CID-3000/Switch-from-app-n…

…ame-to-slug CID-3000: Switch from app name to slug
leanix · Oct 16, 2024 · 7d0a6db · 7d0a6db
2 parents 4b170e0 + f9ab68c
commit 7d0a6db
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/main/kotlin/net/leanix/githubagent/dto/GitHubAppResponse.kt b/src/main/kotlin/net/leanix/githubagent/dto/GitHubAppResponse.kt
@@ -5,7 +5,7 @@ import com.fasterxml.jackson.annotation.JsonProperty
 
 @JsonIgnoreProperties(ignoreUnknown = true)
 data class GitHubAppResponse(
-    @JsonProperty("name") val name: String,
+    @JsonProperty("slug") val slug: String,
     @JsonProperty("permissions") val permissions: Map<String, String>,
     @JsonProperty("events") val events: List<String>
 )
diff --git a/src/main/kotlin/net/leanix/githubagent/runners/PostStartupRunner.kt b/src/main/kotlin/net/leanix/githubagent/runners/PostStartupRunner.kt
@@ -36,7 +36,7 @@ class PostStartupRunner(
         val jwt = cachingService.get("jwtToken") as String
         webSocketService.sendMessage(
             APP_NAME_TOPIC,
-            gitHubEnterpriseService.getGitHubApp(jwt).name
+            gitHubEnterpriseService.getGitHubApp(jwt).slug
         )
         gitHubScanningService.scanGitHubResources()
     }

diff --git a/src/main/kotlin/net/leanix/githubagent/services/GitHubEnterpriseService.kt b/src/main/kotlin/net/leanix/githubagent/services/GitHubEnterpriseService.kt
@@ -20,7 +20,7 @@ class GitHubEnterpriseService(private val githubClient: GitHubClient) {
         runCatching {
             val githubApp = getGitHubApp(jwt)
             validateGithubAppResponse(githubApp)
-            logger.info("Authenticated as GitHub App: '${githubApp.name}'")
+            logger.info("Authenticated as GitHub App: '${githubApp.slug}'")
         }.onFailure {
             logger.error("Failed to verify JWT token", it)
             when (it) {

diff --git a/src/test/kotlin/net/leanix/githubagent/services/GitHubEnterpriseServiceTest.kt b/src/test/kotlin/net/leanix/githubagent/services/GitHubEnterpriseServiceTest.kt
@@ -19,7 +19,7 @@ class GitHubEnterpriseServiceTest {
     fun `verifyJwt with valid jwt should not throw exception`() {
         val jwt = "validJwt"
         val githubApp = GitHubAppResponse(
-            name = "validApp",
+            slug = "validApp",
             permissions = mapOf("administration" to "read", "contents" to "read", "metadata" to "read"),
             events = listOf("label", "public", "repository")
         )
@@ -39,7 +39,7 @@ class GitHubEnterpriseServiceTest {
     @Test
     fun `validateGithubAppResponse with correct permissions should not throw exception`() {
         val response = GitHubAppResponse(
-            name = "validApp",
+            slug = "validApp",
             permissions = mapOf("administration" to "read", "contents" to "read", "metadata" to "read"),
             events = listOf("label", "public", "repository")
         )
@@ -50,7 +50,7 @@ class GitHubEnterpriseServiceTest {
     @Test
     fun `validateGithubAppResponse with missing permissions should throw exception`() {
         val response = GitHubAppResponse(
-            name = "validApp",
+            slug = "validApp",
             permissions = mapOf("administration" to "read", "contents" to "read"),
             events = listOf("label", "public", "repository")
         )
@@ -63,7 +63,7 @@ class GitHubEnterpriseServiceTest {
     @Test
     fun `validateGithubAppResponse with missing events should throw exception`() {
         val response = GitHubAppResponse(
-            name = "validApp",
+            slug = "validApp",
             permissions = mapOf("administration" to "read", "contents" to "read", "metadata" to "read"),
             events = listOf("label", "public")
         )