Updates to MapTiler and NLS #605
Open
+155
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapTiler: - Update NLS for different formats and zoom levels and add Bartholomew Quarter-Inch map of Ireland - Add MapTilerTiles (still incomplete)
MapTiler updates: - NLS, taking care of different formats and zoom levels + add Bartholomew Quarter Inch map of Ireland - new MapTilerTiles, still incomplete
|
Just a moment. For some reason I forgot to add 'options' first! Update: should be fine now. |
nest options in 'options'
|
Thx ! Primary this should be rebased with a proper commit log, can you do it please ? I'm not sure about adding pbf tiles since it depends on an external plugin. To me, the principle of leaflet provider is to provide tiles ready to user with leaflet. Any thoughts about this @jieter ? |
|
I'm certain that mixing xyz tiles with pbf would cause a lot of confusion downstream. It would certainly break everything over in Python where we consume leaflet-providers data. |
improvements to MapTilerTiles and NLS: - remove variants not supported by Leaflet
|
@martinfleis ths for the feedback & thx also @D-Groenewegen for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapTiler updates: