-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Marching Ants animation to docs #393
Conversation
Signed-off-by: Alero Awani <aleroawani18@gmail.com>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quality work, @Alero-Awani.
Is there an existing section with code snippet that needs to be replaced?
I thought that we had a yaml or json example in here somewhere. It can make sense to continue to have as a behind-the-scenes way of setting this animation (instead of using the mouse to do it), but we'll need to make sure the it is still set in the same way. I don't think that it is. Soooo, we'll either need to delete or update. |
@Alero-Awani Please add it as an agenda item to the meeting minutes. |
adding |
|
@leecalcote This embedded design needs to be replaced with a more complex design. I'll do that and include it in this PR. |
Signed-off-by: Alero Awani <aleroawani18@gmail.com>
Notes for Reviewers
This PR fixes #337
Also changed the embedded design in the Embedding Designs doc to a better design.
Signed commits