Support attributes on hier, BULLETS and ITEMS, fixes #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
longhotsummer
commented
Mar 18, 2022
•
longhotsummer
commented
- support block attributes for BULLETS and ITEMS
- ensure empty body documents are valid xml
- fix hcontainers for crossheadings at the top level
longhotsummer
changed the title
longhotsummer
changed the title
|
Closes #61 |
|
crossHeadings are still broken. Working on it. |
|
Crossheadings fixed |
goose-life
reviewed
Mar 22, 2022
| <body> | ||
| <section eId="hierarchicalStructure_1__sec_nn_1"> | ||
| <crossHeading eId="hierarchicalStructure_1__sec_nn_1__crossHeading_1">crossheading one</crossHeading> | ||
| <wrapUp> |
There was a problem hiding this comment.
oof I don't like this! 😅
There was a problem hiding this comment.
:D What's the alternative? We can also determine that the section doesn't have any "real" content before the blockList, so the blockList then goes into an hcontainer? That's not particularly pretty either.
There was a problem hiding this comment.
Yeah it is what it is! :)
goose-life
previously approved these changes
Mar 22, 2022
longhotsummer
commented
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.