Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes: Display fallback icons on a reasonable size on HTML notes #11448

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Nov 26, 2024

Fixes https://discourse.joplinapp.org/t/huge-black-arrows-in-html-emails/41498

Summary

The issue the user reports happens when an HTML note (webclipper/email-to-note) is synchronized but not all resources have been downloaded yet. When that happens a fallback icon is rendered in the place of it.

The problem is that for the icon to be in a reasonable size, some CSS rules are applied.

The HTML note shouldn't need most of our CSS rules, so these basic rules are only applied to the Markdown notes.

Testing

  1. Use webclipper to save a page with a lot of images
  2. Synchronize to a remote server
  3. Remove local files (e.g.: delete ~/.config/joplindev-desktop/)
  4. Reopen the Desktop app
  5. When the Fetch Items has finished, the note from the clipper should appear in the list
  6. Stop the synchronisation by shutting down the server/shutting down the internet or observe the note while the resource is being downloaded
  7. The icons should be shown in a reasonable size like the image below
    image

@pedr pedr added the bug It's a bug label Nov 26, 2024
@pedr pedr requested a review from laurent22 November 26, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant