Desktop: Fixes: Display fallback icons on a reasonable size on HTML notes #11448
+24
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://discourse.joplinapp.org/t/huge-black-arrows-in-html-emails/41498
Summary
The issue the user reports happens when an HTML note (webclipper/email-to-note) is synchronized but not all resources have been downloaded yet. When that happens a fallback icon is rendered in the place of it.
The problem is that for the icon to be in a reasonable size, some CSS rules are applied.
The HTML note shouldn't need most of our CSS rules, so these basic rules are only applied to the Markdown notes.
Testing
~/.config/joplindev-desktop/
)Fetch Items
has finished, the note from the clipper should appear in the list