Skip to content

Commit

Permalink
Remove unnecessary differences in HTML between rendered forms.
Browse files Browse the repository at this point in the history
  • Loading branch information
thijskh committed Jan 14, 2024
1 parent 463adb4 commit 08cc743
Showing 1 changed file with 10 additions and 11 deletions.
21 changes: 10 additions & 11 deletions auth_mellon_handler.c
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ static int am_set_logout_response_post_content(request_rec *r,
" <input type=\"hidden\" name=\"SAMLResponse\" value=\"%s\">\n"
" <input type=\"hidden\" name=\"RelayState\" value=\"%s\">\n"
" <noscript>\n"
" <input type=\"submit\">\n"
" <input type=\"submit\" value=\"Proceed\">\n"
" </noscript>\n"
" </form>\n"
" </body>\n"
Expand All @@ -634,7 +634,7 @@ static int am_set_logout_response_post_content(request_rec *r,
" <form method=\"POST\" action=\"%s\">\n"
" <input type=\"hidden\" name=\"SAMLResponse\" value=\"%s\">\n"
" <noscript>\n"
" <input type=\"submit\">\n"
" <input type=\"submit\" value=\"Proceed\">\n"
" </noscript>\n"
" </form>\n"
" </body>\n"
Expand Down Expand Up @@ -2886,19 +2886,18 @@ static int am_handle_repost(request_rec *r)
}

output = apr_psprintf(r->pool,
"<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//EN\">\n"
"<!DOCTYPE html>\n"
"<html>\n"
" <head>\n"
" <title>SAML rePOST request</title>\n"
" </head>\n"
" <body onload=\"document.getElementById('form').submit();\">\n"
" <noscript>\n"
" Your browser does not support Javascript, \n"
" you must click the button below to proceed.\n"
" </noscript>\n"
" <form id=\"form\" method=\"POST\" action=\"%s\" enctype=\"%s\"%s>\n%s"
" <body onload=\"document.forms[0].submit()\">\n"
" <noscript>\n"
" <strong>Note:</strong> Since your browser does not support JavaScript, you must press the button below once to proceed.\n"
" </noscript>\n"
" <form method=\"POST\" action=\"%s\" enctype=\"%s\"%s>\n%s"
" <noscript>\n"
" <input type=\"submit\">\n"
" <input type=\"submit\" value=\"Proceed\">\n"
" </noscript>\n"
" </form>\n"
" </body>\n"
Expand Down Expand Up @@ -3014,7 +3013,7 @@ static int am_set_authn_request_post_content(request_rec *r, LassoLogin *login)
" <input type=\"hidden\" name=\"SAMLRequest\" value=\"%s\">\n"
" <input type=\"hidden\" name=\"RelayState\" value=\"%s\">\n"
" <noscript>\n"
" <input type=\"submit\">\n"
" <input type=\"submit\" value=\"Proceed\">\n"
" </noscript>\n"
" </form>\n"
" </body>\n"
Expand Down

0 comments on commit 08cc743

Please sign in to comment.