Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stripe/stripe-php to v16 #1721

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

karkowg
Copy link
Contributor

@karkowg karkowg commented Oct 30, 2024

Bump stripe/stripe-php to latest version (16.2). Some Stripe features like invoice preview were not available prior to 15.x.

@driesvints driesvints self-assigned this Oct 30, 2024
@karkowg
Copy link
Contributor Author

karkowg commented Oct 30, 2024

I have a couple of tests failing locally that I have yet to find the time to investigate.

There were 2 errors:

1) Laravel\Cashier\Tests\Feature\CustomerTest::test_customers_can_generate_a_billing_portal_url
Stripe\Exception\InvalidRequestException: You can’t create a portal session in test mode until you save your customer portal settings in test mode at https://dashboard.stripe.com/test/settings/billing/portal.

/cashier-stripe/vendor/stripe/stripe-php/lib/Exception/ApiErrorException.php:38
/cashier-stripe/vendor/stripe/stripe-php/lib/Exception/InvalidRequestException.php:35
/cashier-stripe/vendor/stripe/stripe-php/lib/ApiRequestor.php:230
/cashier-stripe/vendor/stripe/stripe-php/lib/ApiRequestor.php:191
/cashier-stripe/vendor/stripe/stripe-php/lib/ApiRequestor.php:637
/cashier-stripe/vendor/stripe/stripe-php/lib/ApiRequestor.php:136
/cashier-stripe/vendor/stripe/stripe-php/lib/BaseStripeClient.php:184
/cashier-stripe/vendor/stripe/stripe-php/lib/Service/AbstractService.php:75
/cashier-stripe/vendor/stripe/stripe-php/lib/Service/BillingPortal/SessionService.php:25
/cashier-stripe/src/Concerns/ManagesCustomer.php:465
/cashier-stripe/tests/Feature/CustomerTest.php:96

2) Laravel\Cashier\Tests\Feature\CustomerTest::test_customers_can_be_redirected_to_their_billing_portal
Stripe\Exception\InvalidRequestException: You can’t create a portal session in test mode until you save your customer portal settings in test mode at https://dashboard.stripe.com/test/settings/billing/portal.

/cashier-stripe/vendor/stripe/stripe-php/lib/Exception/ApiErrorException.php:38
/cashier-stripe/vendor/stripe/stripe-php/lib/Exception/InvalidRequestException.php:35
/cashier-stripe/vendor/stripe/stripe-php/lib/ApiRequestor.php:230
/cashier-stripe/vendor/stripe/stripe-php/lib/ApiRequestor.php:191
/cashier-stripe/vendor/stripe/stripe-php/lib/ApiRequestor.php:637
/cashier-stripe/vendor/stripe/stripe-php/lib/ApiRequestor.php:136
/cashier-stripe/vendor/stripe/stripe-php/lib/BaseStripeClient.php:184
/cashier-stripe/vendor/stripe/stripe-php/lib/Service/AbstractService.php:75
/cashier-stripe/vendor/stripe/stripe-php/lib/Service/BillingPortal/SessionService.php:25
/cashier-stripe/src/Concerns/ManagesCustomer.php:465
/cashier-stripe/src/Concerns/ManagesCustomer.php:481
/cashier-stripe/tests/Feature/CustomerTest.php:106

@karkowg
Copy link
Contributor Author

karkowg commented Oct 31, 2024

@driesvints looks like I was just missing enabling a customer portal link on my Stripe account. All tests are passing now. Please let me know if I've missed anything else.

image

@taylorotwell taylorotwell marked this pull request as draft October 31, 2024 17:48
@taylorotwell
Copy link
Member

taylorotwell commented Oct 31, 2024

Drafting pending @driesvints review

@driesvints driesvints marked this pull request as ready for review November 6, 2024 07:52
@driesvints driesvints merged commit abbf124 into laravel:15.x Nov 7, 2024
9 checks passed
@driesvints
Copy link
Member

We'll give this a shot.

@karkowg karkowg deleted the bump-stripe-version branch November 7, 2024 21:37
@karkowg karkowg restored the bump-stripe-version branch November 7, 2024 21:38
@sts-ryan-holton
Copy link

@driesvints @taylorotwell Can I just check that this change doesn't require updating to 2024-10-28.acacia in my Stripe account? There's a new Stripe version available

@driesvints
Copy link
Member

Your account is separate from the SDK. You'll see incoming API requests from the new version but can leave your account on the old one.

@sts-ryan-holton
Copy link

Any plan to update to 2024-10-28.acacia soon?

@driesvints
Copy link
Member

Why do you specifically need it?

@sts-ryan-holton
Copy link

I don't specifically need it at this point, I just thought that I wouldn't be able to update to Cashier Strip v15.5.0 because it changes Stripe to v16, but I haven't updated to the newer Stripe API version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants