Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port potential Databox enhancements into Spiner from Singe -- transformations #95

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

Port potential Databox enhancements into Spiner from Singe -- transformations #95

wants to merge 49 commits into from

Commits on Sep 19, 2024

  1. Copy databox_wrapper.hpp from Singe as a starting point for discussion.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    216d115 View commit details
    Browse the repository at this point in the history

  2. Notes

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ac86b2f View commit details
    Browse the repository at this point in the history

  3. Notes again

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7d0865a View commit details
    Browse the repository at this point in the history

  4. Start adding the transformations.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f99c241 View commit details
    Browse the repository at this point in the history

  5. Started writing the transformations.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e0e8b0a View commit details
    Browse the repository at this point in the history

  6. Modify RegularGrid1D to allow for transformations.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5ce03cb View commit details
    Browse the repository at this point in the history

  7. Forgot include

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    be1acd1 View commit details
    Browse the repository at this point in the history

  8. Forgot (a) some templates and (b) static.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fc0f83f View commit details
    Browse the repository at this point in the history

  9. I removed dx() from RegularGrid1D, so update the tests.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    622c8fb View commit details
    Browse the repository at this point in the history

  10. Tests for transformations.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2eccab5 View commit details
    Browse the repository at this point in the history

  11. Add Transform template to DataBox (currently doesn't do anything yet).

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    becaae9 View commit details
    Browse the repository at this point in the history

  12. Update TODO items

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    18cd066 View commit details
    Browse the repository at this point in the history

  13. Add dependent variable transformation.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    af53549 View commit details
    Browse the repository at this point in the history

  14. Update TODO items

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4f8fbe2 View commit details
    Browse the repository at this point in the history

  15. Update TODO items

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6e292a0 View commit details
    Browse the repository at this point in the history

  16. Add GPU testing for transformations.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fa2dd5b View commit details
    Browse the repository at this point in the history

  17. Delete a bunch of stuff we no longer need.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c54a6a5 View commit details
    Browse the repository at this point in the history

  18. Move existing RegularGrid1D test to a new file, so I can add new test… 

    …ing of the new feature without further adding to the overcrowdedness of test.cpp.
    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    15aa48a View commit details
    Browse the repository at this point in the history

  19. Add some testing with transformations.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    222bdae View commit details
    Browse the repository at this point in the history

  20. Add a TODO

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0bc4e32 View commit details
    Browse the repository at this point in the history

  21. test tags

    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    db0323c View commit details
    Browse the repository at this point in the history

  22. Add tests for DataBox with transformations. The current results seem … 

    …to indicate that the independent variable transformations are correct but the depending variable transformation is incorrect.
    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d45bcc6 View commit details
    Browse the repository at this point in the history

  23. Starting to fix operator(). Mostly lots of stream-of-consciousness no… 

    …tes, writing down ideas to resolve this as I thought of them.
    @BrendanKKrueger
    BrendanKKrueger committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    37f3840 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Fix some things about accessing the dependent variable values.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    958062e View commit details
    Browse the repository at this point in the history

  2. Revise discussion of operator() and accessors.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    57ddf50 View commit details
    Browse the repository at this point in the history

  3. Remove long TODO discussion, because it's better as a comment on the PR.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    4734797 View commit details
    Browse the repository at this point in the history

  4. Add transformations to PiecewiseGrid1D.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ed811b5 View commit details
    Browse the repository at this point in the history

  5. We'll push extrapolations to another MR.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    78594ea View commit details
    Browse the repository at this point in the history

  6. Moving some TODO comments to MR discussion.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    cac4be1 View commit details
    Browse the repository at this point in the history

  7. Moving some TODO comments to MR discussion.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8ab5205 View commit details
    Browse the repository at this point in the history

  8. Edit TODO.

    @BrendanKKrueger
    BrendanKKrueger committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a178359 View commit details
    Browse the repository at this point in the history

  9. format

    @BrendanKKrueger
    BrendanKKrueger committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c7afa64 View commit details
    Browse the repository at this point in the history

  10. missing header

    @BrendanKKrueger
    BrendanKKrueger committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    28bcf26 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Update spiner/transformations.hpp 

    Co-authored-by: Jonah Miller <jonah.maxwell.miller@gmail.com>
    @BrendanKKrueger @Yurlungur
    BrendanKKrueger and Yurlungur authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    51d11c8 View commit details
    Browse the repository at this point in the history

  2. force inline

    @BrendanKKrueger
    BrendanKKrueger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    df8f052 View commit details
    Browse the repository at this point in the history

  3. constexpr

    @BrendanKKrueger
    BrendanKKrueger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2f39150 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Documentation

    @BrendanKKrueger
    BrendanKKrueger committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8d76c55 View commit details
    Browse the repository at this point in the history

  2. documentation again

    @BrendanKKrueger
    BrendanKKrueger committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    09c3aed View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Change logarithmic transform's epsilon value.

    @BrendanKKrueger
    BrendanKKrueger committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    45fe193 View commit details
    Browse the repository at this point in the history

  2. format

    @BrendanKKrueger
    BrendanKKrueger committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8578f89 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge branch 'main' into bkk_wrapper

    @Yurlungur
    Yurlungur authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    9aaa291 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Switch from SFINAE to static_assert so that we can give a better erro… 

    …r message.
    @BrendanKKrueger
    BrendanKKrueger committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5942d20 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. x is the 'ground truth' representation, so fix the bounds.

    @BrendanKKrueger
    BrendanKKrueger committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    624d244 View commit details
    Browse the repository at this point in the history

  2. Cleaning up things that should (probably?) be private.

    @BrendanKKrueger
    BrendanKKrueger committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0486a9d View commit details
    Browse the repository at this point in the history

  3. More cleanup

    @BrendanKKrueger
    BrendanKKrueger committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    aba2fd4 View commit details
    Browse the repository at this point in the history

  4. Expanded tests for RegularGrid1D.

    @BrendanKKrueger
    BrendanKKrueger committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    82fe518 View commit details
    Browse the repository at this point in the history

  5. Expand TODO comment.

    @BrendanKKrueger
    BrendanKKrueger committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ab02e9f View commit details
    Browse the repository at this point in the history

  6. format

    @BrendanKKrueger
    BrendanKKrueger committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1955937 View commit details
    Browse the repository at this point in the history

  7. format (again... doing it manually because clang-format here and on G… 

    …itHub don't always agree)
    @BrendanKKrueger
    BrendanKKrueger committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    fce0f56 View commit details
    Browse the repository at this point in the history