Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable C++17 #94

Merged
merged 1 commit into from
Aug 15, 2024
Merged

enable C++17 #94

merged 1 commit into from
Aug 15, 2024

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

Bump to C++17. It's finally time @mauneyc-LANL

PR Checklist

  • Code is formatted. (You can use the format_spiner make target.)
  • Adds a test for any bugs fixed. Adds tests for new features.
  • If preparing for a new release, update the version in cmake.

@Yurlungur Yurlungur self-assigned this Aug 15, 2024
@mauneyc-LANL
Copy link
Collaborator

As I said in lanl/ports-of-call#39, I'll wait on these to get in so I can make some better use of 17 (apply! (1 + ...)!!

@Yurlungur Yurlungur merged commit fe1bf60 into main Aug 15, 2024
4 checks passed
@Yurlungur Yurlungur deleted the jmm/cxx17 branch August 15, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauneyc-LANL mauneyc-LANL mauneyc-LANL approved these changes

@dholladay00 dholladay00 Awaiting requested review from dholladay00

@jhp-lanl jhp-lanl Awaiting requested review from jhp-lanl

Assignees

@Yurlungur Yurlungur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yurlungur @mauneyc-LANL @jonahm-LANL