Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config_summary to Spiner. #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

BrendanKKrueger
Copy link
Collaborator

PR Summary

As with Ports-of-Call:

  • The config_summary stuff is something we put together for Singe because we've found it useful in other projects. If you're not interested in adding this to Spiner, feel free to close this MR.
  • This is just an attempt to add config_summary and may not be set up the way you like. Feel free to tweak it or ask me to adjust things.

I'm not positive, but it seems like spiner_content_declare may not be setting up the <packagename>_VERSION variables, which causes the output from config_summary to look weird. This may suggest I need to fix config_summary, someone needs to fix spiner_content_declare, or Spiner just shouldn't mix the two together.

Example screenshot of config_summary output:
screenshot

PR Checklist

  • Code is formatted. (You can use the format_spiner make target.)
  • Adds a test for any bugs fixed. Adds tests for new features.
  • If preparing for a new release, update the version in cmake.

@BrendanKKrueger
Copy link
Collaborator Author

I ran into this issue elsewhere (for example lanl/ports-of-call#65), and the issue is probably that we need to export the version flag to the parent scope. But I may have to play with things a bit to get spiner_content_declare to handle it all correctly, because it's not as simple as searching for find_package and adding the appropriate set command. Making a note for when someone (possibly future-me) gets around to addressing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant