Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nulib reader #57

Merged
merged 4 commits into from
Nov 21, 2024
Merged

nulib reader #57

merged 4 commits into from
Nov 21, 2024

Conversation

Yurlungur
Copy link
Collaborator

Reads nulib data. Needs my fork of nulib, see: Yurlungur/NuLib#1

@Yurlungur Yurlungur self-assigned this Nov 20, 2024
AstroBarker
AstroBarker approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@AstroBarker AstroBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It looks good to me, I think. I hack-tested it by putting a call to LoadFromNuLib_ with a nulib table in the test constructor and it didn't crash.

@Yurlungur
Copy link
Collaborator Author

Good enough for me. Thanks @AstroBarker . Gonna merge this. Then at some point one of us should put it into phoebus for real.

@Yurlungur Yurlungur merged commit 9d0a1b7 into main Nov 21, 2024
1 check passed
@Yurlungur Yurlungur deleted the jmm/nulib-reader branch November 21, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstroBarker AstroBarker AstroBarker approved these changes

@brryan brryan Awaiting requested review from brryan

Assignees

@Yurlungur Yurlungur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yurlungur @AstroBarker @jonahm-LANL