New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reference to old cuda_compatibility patch #424

Merged

Yurlungur merged 2 commits into main from blb/fix_gpu_patch_call

Oct 14, 2024

Collaborator

AstroBarker commented Oct 14, 2024

The variant patch erroneously referenced the old cuda_compatibility.patch. This PR fixes that to point to gpu_compatibility.patch.

Adds a test for any bugs fixed. Adds tests for new features.
Format your changes by using the make format command after configuring with cmake.
Document any new features, update documentation for changes made.
Make sure the copyright notice on any files you modified is up to date.
After creating a pull request, note it in the CHANGELOG.md file.
LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

Update the version in cmake.
Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
Ensure that any when='@main' dependencies are updated to the release version in the package.py


          fix: broken reference to cuda_compatibility.patch

f2aaf80

AstroBarker added the bug label

AstroBarker requested a review from Yurlungur

October 14, 2024 22:17


          changelog

e346cae

Yurlungur approved these changes

View reviewed changes

Collaborator

Yurlungur left a comment

Thanks for the fix!

Yurlungur merged commit d443cb5 into main

6 checks passed

Yurlungur deleted the blb/fix_gpu_patch_call branch

October 14, 2024 22:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug