Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial][bugfix] add include guard #406

Merged
merged 2 commits into from
Aug 14, 2024
Merged

[trivial][bugfix] add include guard #406

merged 2 commits into from
Aug 14, 2024

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Aug 14, 2024

PR Summary

In PR #330 I missed an include guard in the new tests. Here the guard is added. Resolves #405 .

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@Yurlungur Yurlungur added bug Something isn't working Testing Additions/changes to the testing infrastruture labels Aug 14, 2024
@Yurlungur Yurlungur self-assigned this Aug 14, 2024
Copy link
Collaborator

@jhp-lanl jhp-lanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jhp-lanl
Copy link
Collaborator

As a note for the future (or an additional one line change to add to this MR) would we maybe want to consider removing the spiner build from the minimal tests on github?

-DSINGULARITY_USE_SPINER=ON \

@Yurlungur
Copy link
Collaborator Author

As a note for the future (or an additional one line change to add to this MR) would we maybe want to consider removing the spiner build from the minimal tests on github?

-DSINGULARITY_USE_SPINER=ON \

Good suggestion. 👍 Done.

@Yurlungur Yurlungur merged commit 497ce65 into main Aug 14, 2024
5 checks passed
@Yurlungur Yurlungur deleted the jmm/bugfix-spiner-test branch August 14, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Testing Additions/changes to the testing infrastruture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests broken when not building with spiner
3 participants