Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spack: avoid broken binutils #379

Merged
merged 1 commit into from
Jun 18, 2024
Merged

spack: avoid broken binutils #379

merged 1 commit into from
Jun 18, 2024

Conversation

rbberger
Copy link
Collaborator

PR Summary

Fixes the re-git CI on Roci by requiring certain binutils versions

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.

@rbberger rbberger requested a review from Yurlungur June 18, 2024 21:58
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a rabbit hole. Thanks for the fix!

@rbberger rbberger merged commit 909b83f into main Jun 18, 2024
5 checks passed
@rbberger rbberger deleted the ci_testing branch June 18, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants