Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose entropy to python api #300

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Expose entropy to python api #300

wants to merge 6 commits into from

Conversation

AstroBarker
Copy link
Collaborator

@AstroBarker AstroBarker commented Aug 31, 2023

Extended code to expose the entropy functionality to the Python API.
Added two additional tests in python_bindings.py that check the entropy functionality in the [Vector EOS] bits.
The Python binding stuff was a bit new to me, so I may well have missed something. It does work for the IdealGas and StellarCollapse models as expected, though.

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • If preparing for a new release, update the version in cmake.

@AstroBarker AstroBarker added the enhancement New feature or request label Aug 31, 2023
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@jhp-lanl
Copy link
Collaborator

@rbberger could you take a look?

Copy link
Collaborator

@rbberger rbberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, although nothing actually sets entropy in EOSState.

@Yurlungur
Copy link
Collaborator

Updated to main. Will merge if tests pass on re-git

@Yurlungur
Copy link
Collaborator

@AstroBarker this PR seems to fail when run on re-git with the full test buildout. Did you ever build the full python machinery when you tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants