-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose entropy to python api #300
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
@rbberger could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, although nothing actually sets entropy
in EOSState
.
Updated to main. Will merge if tests pass on re-git |
@AstroBarker this PR seems to fail when run on re-git with the full test buildout. Did you ever build the full python machinery when you tested? |
Extended code to expose the entropy functionality to the Python API.
Added two additional tests in
python_bindings.py
that check the entropy functionality in the [Vector EOS] bits.The Python binding stuff was a bit new to me, so I may well have missed something. It does work for the
IdealGas
andStellarCollapse
models as expected, though.make format
command after configuring withcmake
.