Change cmake module append to use PROJECT_ insteand of CMAKE_ #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
@jdolence reported an issue downstream when building as submodule !294. The issue was that in submodule mode,
CMAKE_SOURCE_DIR
was pointing to the top-level project's directory and not thesingularity-eos
directory, leading tolist(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake")
not pointing to anything useful.Using
PROJECT_SOURCE_DIR
corrects this by using the proper path to thesingularity-eos
source dir.PR Checklist