Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'condition' to 'condition_bool' #44

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Change 'condition' to 'condition_bool' #44

merged 1 commit into from
Aug 14, 2024

Conversation

jhp-lanl
Copy link
Collaborator

@jhp-lanl jhp-lanl commented Aug 14, 2024 •
edited
Loading

PR Summary

Quick fix to what appears to be a bug where condition was twice in the wrapper for require(). This affects the string stream implementation of PORTABLE_REQUIRE.

Fixes #43

PR Checklist

  • Any changes to code are appropriately documented.
  • Code is formatted.
  • Install test passes.
  • Docs build.
  • N/A If preparing for a new release, update the version in cmake.

@jhp-lanl jhp-lanl linked an issue Aug 14, 2024 that may be closed by this pull request
Bug in require #43
Closed
Yurlungur
Yurlungur approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops good catch!

@Yurlungur Yurlungur merged commit 93833ec into main Aug 14, 2024
3 checks passed
@Yurlungur Yurlungur deleted the 43-bug-in-require branch August 14, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@jonahm-LANL jonahm-LANL Awaiting requested review from jonahm-LANL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in require
2 participants
@jhp-lanl @Yurlungur