Small history fix for FMKS without MHD #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
approved these changes
Oct 26, 2023
src/geometry/geometry.cpp
Outdated
Comment on lines
63
to
64
| const bool do_hydro = pin->GetBoolean("physics", "hydro"); | ||
| if (params.hasKey("xh") && do_hydro) { | ||
| const bool do_mhd = pin->GetOrAddBoolean("fluid", "mhd", false); | ||
| if (params.hasKey("xh") && do_mhd) { |
There was a problem hiding this comment.
Should you check both hydro and mhd? Just to be safe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I wrote the history stuff to compute e.g., mass accretion rate and magnetic flux, I checked that we did indeed
do_hydro.... but not that we are doing MHD. This caused the torus problem without MHD to crash. This should fix that.