Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR implements the radiation number moment evolution equations. Previously, we just evolved the conserved energy and momentum of the radiation field for each species when using the moments. Now, if the parameter
radiation/do_number_evolution
is set, the conserved number density and a corresponding number flux are also evolved for each species. See the Phoebus notes for a description of the equations that are being implemented.This PR also updates to the latest version of Parthenon and changes the type of the integrator to conform with changes made to the Parthenon integration infrastructure.
Things that still need to get done:
FixFluxes
to operate on both number and energy moments (this requires splitting into separate functions for hydro and radiation, at least to minimize code duplication).ApplyFloors
to operate on both number and energy moments.MomentRedshiftingSource
task, which includes the extra RHS terms the number flux equation picks up due to redshifting. This requires calculating the expansion, acceleration, and shear of the fluid 4-velocity field. The expansion and acceleration also need to be included in the asymptotic flux expression.Choices that were made (and that maybe could be unmade):
PR Checklist
scripts/bash/format.sh
.