Fix segfault on restart read? #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brryan
commented
Oct 10, 2022
| @@ -39,7 +39,8 @@ def get_options(): | |||
| host = {} | |||
|
|
|||
| host['NAME'] = os.uname()[1] | |||
| host['COMPILER'] = '/usr/local/hdf5-parallel/bin/h5pcc' | |||
| #host['COMPILER'] = '/usr/local/hdf5-parallel/bin/h5pcc' | |||
| host['COMPILER'] = 'h5pcc' | |||
There was a problem hiding this comment.
Should not be merged like this... but my vm is named ubuntu but my h5pcc isn't at this path. Maybe the solution is turning host['COMPILER'] into an array of strings all of which are searched?
There was a problem hiding this comment.
I don't think I want to do a "search" thing. I think these machine files are intended to be modified... and debian was just a template.
Yurlungur
approved these changes
Oct 10, 2022
| @@ -39,7 +39,8 @@ def get_options(): | |||
| host = {} | |||
|
|
|||
| host['NAME'] = os.uname()[1] | |||
| host['COMPILER'] = '/usr/local/hdf5-parallel/bin/h5pcc' | |||
| #host['COMPILER'] = '/usr/local/hdf5-parallel/bin/h5pcc' | |||
| host['COMPILER'] = 'h5pcc' | |||
There was a problem hiding this comment.
I don't think I want to do a "search" thing. I think these machine files are intended to be modified... and debian was just a template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I can't immediately deduce whether
H5DOpencreates the entire dataset in RAM when called, but this PR closes each processor's dataset right after it is used which should solve the issue if this is indeed the problem.PR Checklist