Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume <jaybenne> #1

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

adamdempsey90
Copy link
Collaborator

I think this is a reasonable change for a code that is a library.

@RyanWollaeger
Copy link
Collaborator

@adamdempsey90 - this change seems reasonable to me, but I don't follow (maybe not enough context) what this addresses.

@adamdempsey90
Copy link
Collaborator Author

@adamdempsey90 - this change seems reasonable to me, but I don't follow (maybe not enough context) what this addresses.

This allows the host code to dictate what the "jaybenne" input block is called. In artemis, for example, we (I) may want to have

<radiation/imc>
# jaybenne parameters

and not

<jaybenne>
# jaybenne parameters

This also allows the host code to add parameters to the jaybenne block (since in my example it's more generically the IMC block).

Copy link
Collaborator

@RyanWollaeger RyanWollaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants