Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dsi abstractions #123

Merged
merged 15 commits into from
Nov 14, 2024
Merged

Dsi abstractions #123

merged 15 commits into from
Nov 14, 2024

Conversation

Vedant1
Copy link
Collaborator

@Vedant1 Vedant1 commented Nov 4, 2024

  • created one joint dsi_relations table in collection rather than one per ingested data source
  • schema reader to load relations for data source into dsi_relations
  • added sqlite reader to sqlite.py for a sqlite reader -> plugin writer workflow instead of just a plugin reader -> sqlite writer workflow
  • updated er diagram writer to use data from collections not a sqlite db directly
  • organized coreterminal to show sqlite reader use case and also er diagram writer

core.py

  1. added sqlite reader capabilities in artifact_handler
  2. close backends when unloading them
  3. if table exists in current collection, new data is appended to it in transload()

@jpulidojr jpulidojr self-requested a review November 7, 2024 19:46
Copy link
Collaborator

@jpulidojr jpulidojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined sqlite class with new read, write. Made additional changes for upstream code CI tests

@jpulidojr jpulidojr merged commit b9e691b into main Nov 14, 2024
4 checks passed
@jpulidojr jpulidojr deleted the dsi_abstractions branch November 14, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants