Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returning InnerResponse on show functions #36

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ElhamAryanpur
Copy link
Contributor

I thought this'd be useful for cases when user wants to listen to senses. This does not break any of existing code, and is implemented for both backends. Very small adjustment.

@ElhamAryanpur
Copy link
Contributor Author

ElhamAryanpur commented Mar 25, 2024

testing this again, I'm not getting any click sense responses. is this normal behavior?

@lampsitter
Copy link
Owner

This seems reasonable to me.

testing this again, I'm not getting any click sense responses. is this normal behavior?

It returns the response for allocate_ui_with_layout which does not have any click interaction. So to detect clicks, the response for buttons etc. must most likely be propagated.

@ElhamAryanpur
Copy link
Contributor Author

This seems reasonable to me.

testing this again, I'm not getting any click sense responses. is this normal behavior?

It returns the response for allocate_ui_with_layout which does not have any click interaction. So to detect clicks, the response for buttons etc. must most likely be propagated.

That is true, I assumed at first that the allocate_ui_with_layout does return click sense. Guess I was wrong haha

@lampsitter lampsitter merged commit 2dac313 into lampsitter:master Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants