Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove self.kwargs leftover argument #2198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove self.kwargs leftover argument #2198

wants to merge 1 commit into from
+1 −1

Conversation

mossjacob
Copy link

@mossjacob mossjacob commented Nov 21, 2024 •
edited
Loading

Looks like self.kwargs was not removed properly in the add_new_from_columns function, calls to which were failing because of an unexpected argument.

See this blame for the cause

@falexwolf
Copy link
Member

Ping @sunnyosun! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnyosun sunnyosun Awaiting requested review from sunnyosun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mossjacob @falexwolf