-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included headers changes after running include-what-you-use tool #1503
base: master
Are you sure you want to change the base?
Conversation
…truct ppdev_frob_struct’
This is the profiling logs using Clang Build Analyzer tool as explained in the wiki.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1503 +/- ##
==========================================
- Coverage 53.84% 53.84% -0.01%
==========================================
Files 442 442
Lines 53850 53844 -6
==========================================
- Hits 28996 28992 -4
+ Misses 24854 24852 -2 ☔ View full report in Codecov by Sentry. |
The build times seem to be also roughly the same on my tests:
Going from
The script: #!/bin/bash
rm -rf visp-build-time
mkdir visp-build-time && cd visp-build-time
cmake ../visp -DBUILD_JAVA=OFF -DENABLE_AVX=ON
SECONDS=0
# make -j12
make -j4
duration=$SECONDS
echo ""
echo "$((duration / 60)) minutes and $((duration % 60)) seconds elapsed." |
The objective of this PR is to see if suggestions reported by include-what-you-use (IWYU) tool can speed up ViSP build process.
IWYU can be tested following
ci/docker/ubuntu-24.04-IWYU/README.md
instructions.time make -j10
we obtain:For the moment I'm not convinced:
If you have an opinion, I'd be interested (@SamFlt @rolalaro @s-trinh and others...)