Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for ViSP Canny implementation #1490

Merged
merged 12 commits into from
Nov 6, 2024

Commits on Oct 29, 2024

  1. [FIX] Fixed Canny list of edges

    Weak edges that turned into strong edges were not added to the list of edges.
    LAGNEAU Romain committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d9d56b3 View commit details
    Browse the repository at this point in the history
  2. [FIX] Added vpDisplayFactory safeguard

    Check if C++ standard is greater or equal to C++11 before calling createDisplay, otherwise call allocateDisplay and free the memory at the end of the program
    LAGNEAU Romain committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ca2656e View commit details
    Browse the repository at this point in the history
  3. [TUTO][CLEAN] Cleaned options management in Canny tutorial + [TUTO][C…

    …ORE] Added test of edge-list feature
    
    The software arguments management was a bit messy, so introduced a structure holding all the parameters
    
    Introduced a test function to ensure that the edge-list correctly reflect the Canny output image
    LAGNEAU Romain committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3d1ed82 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. [FIX] Fixed Canny auto-threshold

    Throw an exception when the Canny's ratio are outside the expected boundaries
    LAGNEAU Romain committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1843fcb View commit details
    Browse the repository at this point in the history
  2. [FIX] Fix OpenCV automatic Canny threshold

    LAGNEAU Romain committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    cc3881e View commit details
    Browse the repository at this point in the history
  3. [FIX] Fix Canny auto threshold

    Ensure that lower ratio < upper ratio
    LAGNEAU Romain committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6adf6a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. [CORE] Increased stack size for Canny algo

    LAGNEAU Romain committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4c89a32 View commit details
    Browse the repository at this point in the history
  2. [FIX] + [CORE] Worked on computeCannyThreshold

    [FIX] Removed percentage symbol
    
    [CORE] Added check notFOund in OpenCV implem
    LAGNEAU Romain committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3850515 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. Configuration menu
    Copy the full SHA
    956ca44 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. [CORE] vpCanny Made min stack size an attribute [DOC] Documented stac…

    …k size
    
    [CORE] Made the minimum stack size used in the detect method of the vpCannyEdgeDetection class an attribute that the user can either decrease or increase to meet their requirements.
    
    [DOC]  Documented the fact that the stack size can lead to a segfault when the method is called for particular images and the specificities of each platform
    LAGNEAU Romain committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4fe3eba View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into fix_canny

    LAGNEAU Romain committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    db4b5e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. [FIX] Ensure that initialStackSIze has a value

    LAGNEAU Romain committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9f10679 View commit details
    Browse the repository at this point in the history