-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update brightness tutorial #1482
Update brightness tutorial #1482
Conversation
f0d72fb
to
3a553d8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1482 +/- ##
==========================================
+ Coverage 53.88% 53.90% +0.02%
==========================================
Files 442 442
Lines 53778 53791 +13
==========================================
+ Hits 28978 28996 +18
+ Misses 24800 24795 -5 ☔ View full report in Codecov by Sentry. |
- display and save both color and gray results - cycle across the different automatic gamma method
7789949
to
8c01918
Compare
8c01918
to
0533dbf
Compare
Not a tutorial code but I have added Can be used with one image:
or with a sequence of images:
I don't know if the inverse Gamma is needed here: visp/modules/imgproc/src/vpImgproc.cpp Line 332 in a65eebc
Without
With |
…tected on Apple M1 Pro, while there is no segfault on CI! There was an out of range memory access to computation_times vector. % ./tutorial-compare-auto-gamma --input Sample_low_brightness.png --output Results/cube Input: Sample_low_brightness.png Process on half image resolution? 0 Gaussian kernel size: 3 Gaussian standard deviation: 1 Aperture size: 3 Canny filtering type: 0 RGB colorspace? 0 Output result folder: Results/cube Computation time (gamma_log): 2.30396 ms Computation time (gamma_nonlinear): 1.27197 ms Computation time (gamma_cdf): 2.1228 ms Computation time (gamma_classification): 2.62817 ms Computation time (gamma_spatial_variant): 19.5791 ms Write result to: Results/cube/Sample_low_brightness.jpeg Stats: Nb images: 1 gamma_log: mean=2.1228 ms ; median=2.1228 ms gamma_nonlinear: mean=2.62817 ms ; median=2.62817 ms gamma_cdf: mean=19.5791 ms ; median=19.5791 ms libc++abi: terminating due to uncaught exception of type vpException: Empty vector !
Update brightness tutorial:
vpDisplayFactory
and scale the image by 2 for small display resolution