better naming for reading file into paragraphs

pkg/files/filereader.go

@@ -29,9 +29,9 @@ func Read(name string) string {
 	return string(b)
 }
 
-// ReadLinesWithGaps reads a file and returns a slice of slices of strings, one for each line
+// ReadParagraphs reads a file and returns a slice of slices of strings, one for each line
 // A gap of one or more blank lines is used to split the file into groups
-func ReadLinesWithGaps(name string) [][]string {
+func ReadParagraphs(name string) [][]string {
 	_, callingFile, _, ok := runtime.Caller(1)
 	if !ok {
 		panic("unable to find caller so cannot build path to read file")

pkg/files/filereader_test.go

@@ -36,7 +36,7 @@ func TestReadLinesWithGaps(t *testing.T) {
 			{"test", "file"},
 			{"end"},
 		}
-		actual := ReadLinesWithGaps("./input-with-gaps.txt")
+		actual := ReadParagraphs("./input-with-gaps.txt")
 
 		assert.Equal(t, expected, actual)
 	})

puzzles/day00/main.go

@@ -47,12 +47,11 @@ func sumOfCaloriesCarriedByTopThreeElves(name string) int {
 
 func elvesFromFile(name string) []elf {
 	elves := make([]elf, 0)
-	groups := files.ReadLinesWithGaps(name)
-	for _, group := range groups {
-		elf := elf{
+	paragraphs := files.ReadParagraphs(name)
+	for _, group := range paragraphs {
+		elves = append(elves, elf{
 			totalCalories: ints.ToStringAndSum(group),
-		}
-		elves = append(elves, elf)
+		})
 	}
 	return elves
 }