Merge pull request #45 from kuzzleio/subscribeBugFix

Offline subscription bug fix
kuzzleio · Jan 27, 2016 · 1018cbe · 1018cbe
2 parents b8c42c6 + f73c44e
commit 1018cbe
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 14 deletions.
diff --git a/dist/kuzzle.js b/dist/kuzzle.js
@@ -2671,6 +2671,10 @@ KuzzleRoom.prototype.renew = function (filters, cb) {
     filters = null;
   }
 
+  if (filters) {
+    this.filters = filters;
+  }
+
   /*
    if not yet connected, register itself to the subscriptions list and wait for the
    main Kuzzle object to renew once online
@@ -2681,7 +2685,6 @@ KuzzleRoom.prototype.renew = function (filters, cb) {
     return this;
   }
 
-
   if (this.subscribing) {
     this.queue.push({action: 'renew', args: [filters, cb]});
     return this;
@@ -2695,10 +2698,6 @@ KuzzleRoom.prototype.renew = function (filters, cb) {
   this.callback = cb;
   this.kuzzle.subscriptions.pending[self.id] = self;
 
-  if (filters) {
-    this.filters = filters;
-  }
-
   subscribeQuery.body = this.filters;
   subscribeQuery = this.kuzzle.addHeaders(subscribeQuery, this.headers);
 

diff --git a/dist/kuzzle.min.js b/dist/kuzzle.min.js
diff --git a/dist/kuzzle.min.map b/dist/kuzzle.min.map
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "kuzzle-sdk",
-  "version": "1.3.6",
+  "version": "1.3.7",
   "description": "Official Javascript SDK for Kuzzle",
   "author": "The Kuzzle Team <support@kuzzle.io>",
   "repository": {

diff --git a/src/kuzzleRoom.js b/src/kuzzleRoom.js
@@ -155,6 +155,10 @@ KuzzleRoom.prototype.renew = function (filters, cb) {
     filters = null;
   }
 
+  if (filters) {
+    this.filters = filters;
+  }
+
   /*
    if not yet connected, register itself to the subscriptions list and wait for the
    main Kuzzle object to renew once online
@@ -165,7 +169,6 @@ KuzzleRoom.prototype.renew = function (filters, cb) {
     return this;
   }
 
-
   if (this.subscribing) {
     this.queue.push({action: 'renew', args: [filters, cb]});
     return this;
@@ -179,10 +182,6 @@ KuzzleRoom.prototype.renew = function (filters, cb) {
   this.callback = cb;
   this.kuzzle.subscriptions.pending[self.id] = self;
 
-  if (filters) {
-    this.filters = filters;
-  }
-
   subscribeQuery.body = this.filters;
   subscribeQuery = this.kuzzle.addHeaders(subscribeQuery, this.headers);