fix(engine): do not register config mappings

kuzzleio · Jan 23, 2022 · e2356ff · e2356ff
1 parent 27d70cc
commit e2356ff
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 21 deletions.
diff --git a/lib/engine/AbstractEngine.d.ts b/lib/engine/AbstractEngine.d.ts
@@ -14,7 +14,7 @@ export declare abstract class AbstractEngine<TPlugin extends Plugin> {
      * @param pluginName Used to define http routes
      * @param plugin Plugin instance
      * @param index Name of admin index to store engine documents
-     * @param adminConfigManager ConfigManager instance for admin index to register engine mappings
+     * @param adminConfigManager ConfigManager instance for admin index
      * @param engineConfigManager ConfigManager instance for engine index to create config collection
      */
     constructor(pluginName: string, plugin: Plugin, adminIndex: string, adminConfigManager: ConfigManager, engineConfigManager: ConfigManager);

diff --git a/lib/engine/AbstractEngine.js b/lib/engine/AbstractEngine.js
diff --git a/lib/engine/AbstractEngine.js.map b/lib/engine/AbstractEngine.js.map
diff --git a/lib/engine/AbstractEngine.ts b/lib/engine/AbstractEngine.ts
@@ -30,7 +30,7 @@ export abstract class AbstractEngine<TPlugin extends Plugin> {
    * @param pluginName Used to define http routes
    * @param plugin Plugin instance
    * @param index Name of admin index to store engine documents
-   * @param adminConfigManager ConfigManager instance for admin index to register engine mappings
+   * @param adminConfigManager ConfigManager instance for admin index
    * @param engineConfigManager ConfigManager instance for engine index to create config collection
    */
   constructor (
@@ -48,14 +48,6 @@ export abstract class AbstractEngine<TPlugin extends Plugin> {
     this.engineConfigManager = engineConfigManager;
 
     this.configType = `engine-${this.pluginName}`;
-
-    this.adminConfigManager.register('engine', {
-      properties: {
-        index: { type: 'keyword' },
-        group: { type: 'keyword' },
-        name: { type: 'keyword' },
-      }
-    });
   }
 
   async init (...args): Promise<any> {

diff --git a/lib/engine/EngineContent.d.ts b/lib/engine/EngineContent.d.ts
@@ -11,7 +11,7 @@ export declare type EngineContent = {
      */
     group: string;
     /**
-     * Plugin name
+     * Engine name
      */
     name: string;
 };
diff --git a/lib/engine/EngineContent.ts b/lib/engine/EngineContent.ts
@@ -13,7 +13,7 @@ export type EngineContent = {
   group: string;
 
   /**
-   * Plugin name
+   * Engine name
    */
   name: string;
 };