Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/assets migrate tenant #317

Merged
merged 6 commits into from
Oct 3, 2023
Merged

feat/assets migrate tenant #317

merged 6 commits into from
Oct 3, 2023

Conversation

thomas-mauran
Copy link
Member

assets/migrateTenant

The goal here is to provide a way to migrate assets and associated devices to a new tenant easily

How should this be manually tested?

  • Step 1 : clone and run
  • Step 2 : try the new route
  • Step 3: Check the new doc page

Other changes

  • Adding recoveryQueue from PaaS team to rollback the events
  • Adding Ask functions to deviceService

@thomas-mauran thomas-mauran self-assigned this Sep 28, 2023
@thomas-mauran thomas-mauran changed the title Feat/assets migrate tenant [draft] Feat/assets migrate tenant Sep 29, 2023
@thomas-mauran thomas-mauran marked this pull request as draft September 29, 2023 09:33
rolljee
rolljee requested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@rolljee rolljee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job overall, made some suggested changes.

Targeted branch should be 2-dev, not beta.

Also PR is missing tests :)

lib/modules/asset/AssetService.ts Show resolved Hide resolved
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/asset/AssetService.ts Show resolved Hide resolved
@thomas-mauran thomas-mauran marked this pull request as ready for review September 29, 2023 16:12
@thomas-mauran thomas-mauran changed the title [draft] Feat/assets migrate tenant feat/assets migrate tenant Sep 29, 2023
@rolljee rolljee changed the base branch from beta to 2-dev October 3, 2023 08:31
@rolljee rolljee changed the base branch from 2-dev to beta October 3, 2023 08:33
@rolljee rolljee merged commit ee14c6a into beta Oct 3, 2023
3 checks passed
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

🎉 This PR is included in version 2.4.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rolljee rolljee deleted the feat/assetsMigrateTenant branch October 3, 2023 14:57
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.4.0-temp-ci-debug.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.4.0-temp-ci-debug.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolljee rolljee rolljee approved these changes

@alexandrebouthinon alexandrebouthinon Awaiting requested review from alexandrebouthinon

Assignees

@thomas-mauran thomas-mauran

Labels
released on @beta released on @temp-ci-debug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomas-mauran @rolljee