-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move misplaced comment outside YAML block in storageclass-aws-ebs.yaml #48809
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@imuneeeb, why should we make this change? The PR description doesn't explain. |
@sftim Description added |
#48054 (comment) did suggest the same thing. However, there is something to be said for leaving it in place. If a person fetches https://k8s.io/examples/storage/storageclass/storageclass-aws-ebs.yaml directly, they see the comment. Maybe that's useful to keep. Anyway: the change behaves as described, so: |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 8007c7d5a0220ead0c0f744e535e1b0640e5432c
|
Description
This PR corrects a formatting issue in the
StorageClass
YAML configuration where a comment abouttagSpecification
was mistakenly included inside the YAML block. The comment is now moved outside the YAML block for better clarity.Changes Made
tagSpecification
outside the YAML block.Issue
Closes: #