Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move misplaced comment outside YAML block in storageclass-aws-ebs.yaml #48809

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

imuneeeb
Copy link
Contributor

@imuneeeb imuneeeb commented Nov 22, 2024

Description

This PR corrects a formatting issue in the StorageClass YAML configuration where a comment about tagSpecification was mistakenly included inside the YAML block. The comment is now moved outside the YAML block for better clarity.

Changes Made

  • Moved the comment about tagSpecification outside the YAML block.

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Nov 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2024
Copy link

netlify bot commented Nov 22, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 42824fe
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6740f06537e17c0008609bd1
😎 Deploy Preview https://deploy-preview-48809--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 96bf9f5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67436822b440f60008e6c790
😎 Deploy Preview https://deploy-preview-48809--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Nov 23, 2024

@imuneeeb, why should we make this change? The PR description doesn't explain.

@imuneeeb imuneeeb changed the title Remove comment from storageclass-aws-ebs.yaml Move misplaced comment outside YAML block in storageclass-aws-ebs.yaml Nov 24, 2024
@imuneeeb
Copy link
Contributor Author

@sftim Description added

@sftim
Copy link
Contributor

sftim commented Nov 25, 2024

This PR corrects a formatting issue in the StorageClass YAML configuration where a comment about tagSpecification was mistakenly included inside the YAML block. The comment is now moved outside the YAML block for better clarity.

#48054 (comment) did suggest the same thing. However, there is something to be said for leaving it in place.

If a person fetches https://k8s.io/examples/storage/storageclass/storageclass-aws-ebs.yaml directly, they see the comment. Maybe that's useful to keep.

Anyway: the change behaves as described, so:
LGTM

@tengqm tengqm added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 26, 2024
@tengqm
Copy link
Contributor

tengqm commented Nov 26, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8007c7d5a0220ead0c0f744e535e1b0640e5432c

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit b13e3aa into kubernetes:main Nov 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants