Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include parameterNotFoundAction in Validating Admission Policy documentation #48734

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Lahoussine-Bouhmou
Copy link

Description

This pull request updates the Kubernetes documentation for Validating Admission Policies to include details about the parameterNotFoundAction field in ValidatingAdmissionPolicyBinding.

Changes made:

  • Added a detailed explanation of the parameterNotFoundAction field to the paramRef section in validating-admission-policy.md, describing its purpose, allowed values (Allow and Deny), and behavior.
  • Updated YAML examples (binding-with-param.yaml and binding-with-param-prod.yaml) to include the parameterNotFoundAction field, ensuring consistency with the API requirements.
  • Clarified the importance of setting parameterNotFoundAction for policy bindings that use parameter resources.
  • Highlighted how the field interacts with scenarios where parameters are missing.

This change addresses the omission of parameterNotFoundAction from the documentation, which can lead to misconfigurations or confusion for users configuring admission policies.

…ation

- Added a description of the `parameterNotFoundAction` field to the `paramRef` section of the Validating Admission Policy documentation.
- Clarified the behavior and allowed values (`Allow` and `Deny`) of the `parameterNotFoundAction` field in relevant sections.
- Highlighted the importance of setting `parameterNotFoundAction` for policy bindings using parameter resources.
Updated YAML second example: binding-with-param.yaml to include the required `parameterNotFoundAction` field.
Updated YAML second example: binding-with-param-prod.yaml to include the required `parameterNotFoundAction` field.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

linux-foundation-easycla bot commented Nov 15, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 15, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 15, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Lahoussine-Bouhmou!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 15, 2024
Copy link

netlify bot commented Nov 15, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a06306
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673c548063b0fd00089198cb
😎 Deploy Preview https://deploy-preview-48734--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

@Lahoussine-Bouhmou Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

(To re-trigger EasyCLA bot check)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 16, 2024
@dipesh-rawat
Copy link
Member

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 18, 2024

One of `name` or `selector` must be set, but not both.

**Note:** The `parameterNotFoundAction` field in `paramRef` is **required**. It specifies the action to take when no parameters are found matching the `paramRef`. If not specified, the policy binding may be considered invalid and will be ignored or could lead to unexpected behavior.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use note shortcode here.
Refer the guidance on how to use it : https://kubernetes.io/docs/contribute/style/style-guide/#note

…ss-authn-authz/validating-admission-policy.md


Changed ::
Deny
By:
Deny
```

Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Replaced manual note with note shortcode for the parameterNotFoundAction section as per style guide.
@Lahoussine-Bouhmou
Copy link
Author

@dipesh-rawat
Thank you for the feedback! I've did these commits as requested:

  • Updated the note to use the shortcode.
  • Fixed the missing triple backticks in the code block.

Let me know if there's anything else to adjust!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants