-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include parameterNotFoundAction in Validating Admission Policy documentation #48734
base: main
Are you sure you want to change the base?
Conversation
…ation - Added a description of the `parameterNotFoundAction` field to the `paramRef` section of the Validating Admission Policy documentation. - Clarified the behavior and allowed values (`Allow` and `Deny`) of the `parameterNotFoundAction` field in relevant sections. - Highlighted the importance of setting `parameterNotFoundAction` for policy bindings using parameter resources.
Updated YAML second example: binding-with-param.yaml to include the required `parameterNotFoundAction` field.
Updated YAML second example: binding-with-param-prod.yaml to include the required `parameterNotFoundAction` field.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Lahoussine-Bouhmou! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Lahoussine-Bouhmou Thanks you for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/easycla
(To re-trigger EasyCLA bot check)
/sig api-machinery |
|
||
One of `name` or `selector` must be set, but not both. | ||
|
||
**Note:** The `parameterNotFoundAction` field in `paramRef` is **required**. It specifies the action to take when no parameters are found matching the `paramRef`. If not specified, the policy binding may be considered invalid and will be ignored or could lead to unexpected behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use note
shortcode here.
Refer the guidance on how to use it : https://kubernetes.io/docs/contribute/style/style-guide/#note
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Show resolved
Hide resolved
…ss-authn-authz/validating-admission-policy.md Changed :: Deny By: Deny ``` Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Replaced manual note with note shortcode for the parameterNotFoundAction section as per style guide.
@dipesh-rawat
Let me know if there's anything else to adjust! |
Description
This pull request updates the Kubernetes documentation for Validating Admission Policies to include details about the
parameterNotFoundAction
field inValidatingAdmissionPolicyBinding
.Changes made:
parameterNotFoundAction
field to theparamRef
section invalidating-admission-policy.md
, describing its purpose, allowed values (Allow
andDeny
), and behavior.binding-with-param.yaml
andbinding-with-param-prod.yaml
) to include theparameterNotFoundAction
field, ensuring consistency with the API requirements.parameterNotFoundAction
for policy bindings that use parameter resources.This change addresses the omission of
parameterNotFoundAction
from the documentation, which can lead to misconfigurations or confusion for users configuring admission policies.