Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample CEL expression for rejecting GitRepo volumes is incorrect #48816

Closed
DonaldKellett opened this issue Nov 23, 2024 · 1 comment · Fixed by #48817
Closed

Sample CEL expression for rejecting GitRepo volumes is incorrect #48816

DonaldKellett opened this issue Nov 23, 2024 · 1 comment · Fixed by #48817
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@DonaldKellett
Copy link
Contributor

This is a Bug Report

Problem:

The sample CEL expression under docs/concept/storage/volumes for rejecting gitRepo volumes is incorrect. The correct expression should be:

!has(object.spec.volumes) || !object.spec.volumes.exists(v, has(v.gitRepo))

Proposed Solution:

Update the CEL expression from (incorrect):

has(object.spec.volumes) || !object.spec.volumes.exists(v, has(v.gitRepo))

To (correct):

!has(object.spec.volumes) || !object.spec.volumes.exists(v, has(v.gitRepo))

Page to Update:
https://kubernetes.io/docs/concepts/storage/volumes/

@DonaldKellett DonaldKellett added the kind/bug Categorizes issue or PR as related to a bug. label Nov 23, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 23, 2024
@sftim
Copy link
Contributor

sftim commented Nov 23, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants