Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sample CEL expression in volumes.md #48817

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DonaldKellett
Copy link

Fix sample CEL expression for rejecting gitRepo volumes in volumes.md

Description

Update the sample CEL expression for rejecting gitRepo volumes under docs/concepts/storage/volumes.md from (incorrect):

has(object.spec.volumes) || !object.spec.volumes.exists(v, has(v.gitRepo))

To (correct):

!has(object.spec.volumes) || !object.spec.volumes.exists(v, has(v.gitRepo))

Issue

Fix #48816

Fix sample CEL expression for rejecting gitRepo volumes in volumes.md
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chanieljdan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 23, 2024
Copy link

linux-foundation-easycla bot commented Nov 23, 2024

CLA Signed

  • ✅login: DonaldKellett / (38e7774)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @DonaldKellett!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 23, 2024
Copy link

netlify bot commented Nov 23, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 38e7774
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67417df3cea4470008466b18
😎 Deploy Preview https://deploy-preview-48817--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample CEL expression for rejecting GitRepo volumes is incorrect
2 participants